Repository navigation
ci: alert on Slack when a release publish job fails - #1244
Merged
Patrick Nilan (pnilan) merged 1 commit intoOct 22, 2026
Merged
Conversation
Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1792619061-alert-publish-failure#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1792619061-alert-publish-failurePR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
Patrick Nilan (pnilan)
marked this pull request as ready for review
October 22, 2026 16:40
Patrick Nilan (pnilan)
approved these changes
Oct 22, 2026
Patrick Nilan (pnilan)
deleted the
devin/1792619061-alert-publish-failure
branch
October 22, 2026 18:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/airbytehq/airbyte-internal-issues/issues/18062:
Close on merge: yes — internally filed, no customer to confirm with.
Summary
Adds a final
notify-publish-failurejob to theCDK Publishworkflow (.github/workflows/publish.yml) that posts to Slack when a tag-triggered release fails to publish. Today the only Slack messages come fromupdate-connector-builder, which doesn't depend onpublish_sdm/publish_cdk(so their failures are invisible and it still posts success) and is skipped whenpublish_manifest_serverfails (so its failure message never posts). Example: run 17474487668 had all three publish jobs fail, the Builder job skipped, and no alert; run 32521540962 hadbuildfail with nothing posted.The message includes the version (
needs.build.outputs.VERSION, falling back togithub.ref_namewhenbuilditself failed), the failed job(s), jobs that didn't run (skipped/cancelled because of an upstream failure), and a link to the run. Existing job dependencies are unchanged and there are no Docker Hub retries (both out of scope per the issue).Secret scope: the new job has no
environment:.SLACK_BOT_TOKEN_AIRBYTE_TEAMis already used bynotify-slackinslack-pr-notification.yml, which also has noenvironment:, so it looks like a repo- or org-level secret. I couldn't list the repo's secrets to confirm this (HTTP 403).Case analysis
failure()in a job-levelif:is true when any ancestor job failed. It is false on full success and on cancellation. Without it, a job whoseneedsfailed is skipped.failure()false)publish_sdmfailspublish_manifest_serverfails (Builder job skipped)publish_cdkfailsbuildfails (e.g. bad tagv.7.28.2)workflow_dispatchprerelease, any failureevent_name != 'push')failure()false)The alert step has
continue-on-error: true, and the summary step only classifies strings, so the alert can't fail the workflow. A failure in the alert job would still show on its own job, but it can't turn a successful release red, because the job only runs after something has already failed.Validation
actionlint .github/workflows/publish.yml: no new findings. The output is identical in size (36 lines) tomain, and the findings are pre-existing shellcheck infos in thebuildand Builder jobs.needs.*.resultcombinations above. Example output for abuildfailure:FAILED_JOBS=Build Python PackageandNOT_RUN_JOBS=Publish CDK to PyPI, Publish SDM to DockerHub, Publish Manifest Server to DockerHub.Open decisions for the reviewer
C04J1M66D8B), where the existing release messages go. Should it go to an APIs team channel instead?workflow_dispatchprereleases are excluded because whoever starts one is watching it.update-connector-builderis not inneeds; it already posts its own failure message.Declarative-First Evaluation
N/A: this is a CI workflow change only, with no connector or declarative components.
Test Coverage
This repo has no automated test harness for GitHub Actions workflows. Coverage is
actionlintplus running the summary step's script locally for each scenario (see Validation).Link to Devin session: https://app.devin.ai/sessions/1915791f4159447dadacbafc3d35346d
Open in Devin Desktop: https://app.devin.ai/desktop/session/1915791f4159447dadacbafc3d35346d?variant=devin